Use UsbServiceInfo in modem_callerid#60042
Closed
epenet wants to merge 3 commits intohome-assistant:devfrom
Closed
Use UsbServiceInfo in modem_callerid#60042epenet wants to merge 3 commits intohome-assistant:devfrom
epenet wants to merge 3 commits intohome-assistant:devfrom
Conversation
probot-home-assistant
bot
added
code-quality
has-tests
integration: modem_callerid
integration: usb
small-pr
|
Hey there @tkdrob, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
bdraco
reviewed
Nov 21, 2021
epenet
changed the title
Contributor
Author
|
As requested, I have removed the new constants |
Contributor
Author
|
Marked as draft until #60086 is merged |
epenet
force-pushed
the
medem_callerid-UsbServiceInfo
branch
from
46f15dc to
75643af
Compare
epenet
force-pushed
the
medem_callerid-UsbServiceInfo
branch
from
75643af to
089915b
Compare
epenet
changed the title
Contributor
Author
|
Rebased after merge of #60086 |
Contributor
Author
|
@bdraco before we merge this can you take a look at this discussion? |
Contributor
Author
|
Will reopen after #60140 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Use
UsbServiceInfo(andusbconstants) inmodem_callerid.See home-assistant/architecture#662
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: